[LRUG] Notes from my talk on refactoring

[Richard Livsey]

Yeah, authenticate_with_password would probably take a username and password if done in reality, passing round the params hash isn't very nice. In reality if using OmniAuth/similar you'd probably pass the auth_hash through instead of params.

In the end it's not really about authentication more a case of illustrating the refactoring side of things, so I admit I may have 'cheated' a bit by knowing the outcome when I started off writing the first example :o) 

Glad you enjoyed it!


On Thursday, 23 February 2012 at 16:34, Okpala Ikenna N. wrote:

> Jus finished reading your post.. to put long short.. "Brilliant".
> 
> i am wondering why you have choosen to allow authenticate_with_password(params) to be aware of opening up the params hash. 
> 
> --
> 
> Ikenna
> 
> 
> On Thu, Feb 23, 2012 at 4:03 PM, Richard Livsey <richard at livsey.org (mailto:richard at livsey.org)> wrote:
> > I've written up my notes for the lightning talk I gave on refactoring:
> > 
> > http://livsey.org/blog/2012/02/23/should-your-user-care-about-authentication/
> > 
> > Hopefully it is of interest to someone!
> > 
> > Cheers.
> > 
> > --
> > Richard Livsey
> > Co-Founder, MinuteBase
> > Meeting collaboration made easy
> > http://minutebase.com
> > +44 (0) 7841 260 797 (tel:%2B44%20%280%29%207841%20260%20797)
> > 
> > 
> > _______________________________________________
> > Chat mailing list
> > Chat at lists.lrug.org (mailto:Chat at lists.lrug.org)
> > http://lists.lrug.org/listinfo.cgi/chat-lrug.org
> 
> 
> _______________________________________________
> Chat mailing list
> Chat at lists.lrug.org (mailto:Chat at lists.lrug.org)
> http://lists.lrug.org/listinfo.cgi/chat-lrug.org