[LRUG] A general question about exception handling in services

[Mark Burns]

Nice. I read that article and it points me to a  post I wrote in it.

So we've kind of already modularised monorails into separate services now,
it's interesting that it feels like we could be reaching another complexity
boundary.

On Thursday, 11 April 2013, Chris Parsons wrote:

> On 11 Apr 2013, at 00:00, Mark Burns <markthedeveloper at gmail.com<javascript:_e({}, 'cvml', 'markthedeveloper at gmail.com');>>
> wrote:
>
> Whilst passing enough info up to the controller or route level to execute
> plan_b would be possible it doesn't feel like a clean way to encapsulate
> things.
>
>
> Ok. The only other option might be to turn your domain model on its head
> and use something like a DCI or Hexagonal[1] approach, but that might be a
> step too far at this point - difficult to know if that would help without
> seeing your code + existing domain model.
>
> Introducing yet another moving part would increase our debugging
> complexity a step further though and highlight even more the need for
> improved cross-service logging, etc.
>
>
> That's true, but it sounds like your application has reach the level of
> complexity where queues makes sense, and that investment in good logging
> would be a good one to keep the cost of change curve as flat as possible.
> Ensuring you have some true end-to-end tests is also a good investment as
> the number of moving parts increases.
>
> [1] http://blog.mattwynne.net/2012/04/09/hexagonal-rails-introduction/
>
> On Wednesday, 10 April 2013, Chris Parsons wrote:
>
> How about posting the call to the external API providers to a queue?
>
> You can then return from the request with a good level of surety, and
> track the progress of the external API call, handling any failures and
> retrying as appropriate.
>
> If a queue isn't an option, I tend to use different kinds of Exceptions:
>
> * only catch very specific exceptions from the API calls
> * re-raise my own Exception objects
> * specifically catch my own Exception objects in the top level request
> code and handle as appropriate.
>
> HTH,
> Chris
>
> --
> Chris Parsons
> chris.p at rsons.org
> http://twitter.com/chrismdp
> http://chrismdp.com
>
> BDD Kickstart London, May 22-24, http://bddkickstart.com/dates#london
>
>
> On 10 Apr 2013, at 21:01, Mark Burns <markthedeveloper at gmail.com> wrote:
>
> I get the impression there is a pattern for doing this and probably
> someone on this list has some good input into it.
>
> We've been thinking about how to handle failures in internal services,
> whilst integrating with third party services and trading off robustness and
> ability to debug complex requests and yet still notice actual genuine
> errors in our codebase. (e.g. avoiding things like 'try' and 'rescue nil'
> or 'rescue Exception')
>
> Let's say we have three internal services A,B,C and some external API
> providers X,Y, Z.
>
> Some object may be responsible for communicating with Z, but this object
> doesn't have access to the original incoming request.
> Also it's absolutely critical that if this request to Z fails, the rest of
> the request can complete and the our external API user is hidden from the
> failure and some manual or separate automated process resolves the issue.
>
> To emphasise the criticality of such a system it would be where a user has
> paid for a service and one part of the fulfilment of the customer's
> purchase is achieved by an API call to an external provider Z. If this
> doesn't occur then we'd have angry customers and so we make sure the
> request is fulfilled by any means possible (manual if necessary), but still
> assure the customer we have fulfilled their order.
>
> We've been toying with the idea of generating unique identifiers for our
> incoming requests and sending these in to all other internal services, then
> we'd be able to log these ids in all our log statements. We'd also ideally
> use these ids in communications to airbrake.
>
> We could pretty easily create middleware that can generate the ids and
> send/receive them in headers to our other services, but the issue comes
> with having access to this info in our models.
>
> sinatra route/rails controller code
>  --   some long
>  --   stack frame
>  --  model code communicating with Z
>
> One solution that would get us to our controller/route code where we can
> access the request info would be throwing or raising
> exceptions, but this then prevents us continuing the request in the normal
> way and completing the required tasks after a call to Z fails. Also it's
> horrendous goto flow control.
>
> Other undesirable hacks would be sticking something on the thread itself,
> or a global variable.
>
> The other thing is to actually ensure we can pass down request info all
> the way through a stack, but this completely breaks single responsibility
> and is going to result in complex spa
>
>
>
> --
> Chris Parsons
> chris.p at rsons.org <javascript:_e({}, 'cvml', 'chris.p at rsons.org');>
> http://twitter.com/chrismdp
> http://chrismdp.com
>
> BDD Kickstart London, May 22-24, http://bddkickstart.com/dates#london
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lrug.org/pipermail/chat-lrug.org/attachments/20130411/9518cf7c/attachment-0003.html>