<html><head></head><body bgcolor="#FFFFFF"><div>I would also have a look at code coverage before and after to see if takes a nose dive.<br><br>Bestie</div><div><br>On 19 Sep 2012, at 12:40, Ben Lovell <<a href="mailto:benjamin.lovell@gmail.com">benjamin.lovell@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>On 19 September 2012 12:20, Ian Kynnersley <span dir="ltr"><<a href="mailto:iankynnersley@gmail.com" target="_blank">iankynnersley@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cool, thanks everyone.<div><br></div></blockquote><div><br></div><div>May I also suggest 'Working Effectively with Legacy Code' (Michael C. Feathers)? Some great practical strategies for dealing with exactly these kind of issues.</div>
<div><br></div><div>Cheers,</div><div>Ben</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div></div><div>Consensus seems to be that there isn't a "right" way to do this but that it's probably best not to add tests to verify that you have removed the code as the test suite should describe what the app should be doing not keeping a history of changes.</div>
<div><br></div><div>I think I will remove the code first and verify that the breaking tests are the ones I'm expecting. It seems to make sense to remove the code from the view layer down so that I don't break everything all at once.</div>
<div><br></div><div>Lots of commits also seems like a sensible plan.</div><div><br></div><div>Thanks again,</div><div><br></div><div>Ian</div><div><div><div class="h5"><br><div class="gmail_quote">On Wed, Sep 19, 2012 at 11:46 AM, Paul Battley <span dir="ltr"><<a href="mailto:pbattley@gmail.com" target="_blank">pbattley@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 19 September 2012 10:45, Ian Kynnersley <<a href="mailto:iankynnersley@gmail.com" target="_blank">iankynnersley@gmail.com</a>> wrote:<br>
> ...<br>
<div>> Or should I just delete the code, delete the tests, make<br>
> sure the remaining tests don't fail and stop worrying about it?<br>
<br>
</div>This, I think. I don't see the value in testing the absence of<br>
behaviour in most cases - about the only situation I can readily<br>
imagine is where it's to fulfil a contractual, legal, or regulatory<br>
requirement. I don't think a test suite needs to capture the history<br>
of development, just the current set of operational parameters.<br>
<br>
I might do it the other way around, though: delete tests covering the<br>
functionality, delete the code that satisfies them, then tidy up any<br>
other breakages caused by unwanted side-effects.<br>
<span><font color="#888888"><br>
Paul.<br>
</font></span><div><div>_______________________________________________<br>
Chat mailing list<br>
<a href="mailto:Chat@lists.lrug.org" target="_blank">Chat@lists.lrug.org</a><br>
<a href="http://lists.lrug.org/listinfo.cgi/chat-lrug.org" target="_blank">http://lists.lrug.org/listinfo.cgi/chat-lrug.org</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br>
<br>Ian Kynnersley<br><a href="http://iankynnersley.co.uk" target="_blank">http://iankynnersley.co.uk</a> | <a href="tel:%2B44%20%280%29%207973%20420%20829" value="+447973420829" target="_blank">+44 (0) 7973 420 829</a> | <a href="http://twitter.com/kpopper" target="_blank">http://twitter.com/kpopper</a><br>
</font></span></div>
<br>_______________________________________________<br>
Chat mailing list<br>
<a href="mailto:Chat@lists.lrug.org">Chat@lists.lrug.org</a><br>
<a href="http://lists.lrug.org/listinfo.cgi/chat-lrug.org" target="_blank">http://lists.lrug.org/listinfo.cgi/chat-lrug.org</a><br>
<br></blockquote></div><br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Chat mailing list</span><br><span><a href="mailto:Chat@lists.lrug.org">Chat@lists.lrug.org</a></span><br><span><a href="http://lists.lrug.org/listinfo.cgi/chat-lrug.org">http://lists.lrug.org/listinfo.cgi/chat-lrug.org</a></span><br></div></blockquote></body></html>