<div dir="ltr"><div><i style="font-family:arial,sans-serif">> 4. another member of the team takes a look at the pull request</i><br></div><div><i style="font-family:arial,sans-serif"><br></i></div><div><font face="arial, sans-serif">If I were looking I'd have a fresh CV/cover letter over to you faster than you can say "horizontal privilege escalation".</font></div>
<div><font face="arial, sans-serif"><br></font></div><div><span style="font-family:arial,sans-serif;font-size:13px"><i>> How do you deal with this?</i></span><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif"><br>
</font></div><div><font face="arial, sans-serif">One way I've seen this done before is to have a code review batman who is designated as the person that does code reviews for that time period (be it a week or whatever). Everyone does code reviews, always, but if there is no one available and a change has been lingering/needs to be expedited, batman rolls in and does the review. This only really works if your team is larger than say ten developers.</font></div>
<div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Fun story: at one company we had a technical architect (who was demonic at the command line *and* in his IDE) who was very good at context switching. He managed to deliver a hell of a lot of high quality software, and simultaneously code review literally everything a team of 20+ developers did. Rumour had it that he was some sort of warlock or something, so YMMV.</font></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 19, 2013 at 1:38 PM, Matthew Rudy Jacobs <span dir="ltr"><<a href="mailto:matthewrudyjacobs@gmail.com" target="_blank">matthewrudyjacobs@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">(This is a process question, rather than a Ruby question)<div>
<br></div><div>How do you folks manage getting code from pull request to production?</div><div><br></div><div>At Enthuse.me we work in the following way;</div>
<div><div><ol><li>we take a card<br></li><li>we work on the code until we believe it is done</li><li>we issue a pull request</li><li>another member of the team takes a look at the pull request</li><li>we converse about any issues</li>
<li>we make any changes</li><li>another member of the team merges the pull request</li><li>the code is deployed to the QA server</li><li>the product owner checks the function on QA</li><li>the code is deployed to Production</li>
</ol><div>This all seems to be fine,</div></div><div>but the problem is context switching.</div><div><br></div><div>Steps 4 to 8 can take a couple of days to run through.</div><div><br></div><div>Maybe I finish the code on Friday, but no one is free to review it until Monday.</div>
<div>I start working on something else, then someone raises an issue with my PR.</div><div>When I'm next free I take a look, deal with their questions, make some changes, and ask them to take a look again.</div><div>
<br>
</div><div>That process takes a lot of time, and requires both the reviewer and myself, to switch back and forth.</div><div><br></div><div>How do you deal with this?</div></div><div><br></div></div>
<br>_______________________________________________<br>
Chat mailing list<br>
<a href="mailto:Chat@lists.lrug.org">Chat@lists.lrug.org</a><br>
<a href="http://lists.lrug.org/listinfo.cgi/chat-lrug.org" target="_blank">http://lists.lrug.org/listinfo.cgi/chat-lrug.org</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Ali, <a href="http://happybearsoftware.com" target="_blank">http://happybearsoftware.com</a></div>
</div></div>