[LRUG] [Workflow] Getting a Pull Request from creation to merge

[Bradley Wright]

In the specific case you mentioned nothing is going to solve the weekend context switching problem.

The way we solve this issue (or attempt to) on my team is that we:

a) Put the pull request URL into a comment Pivotal Tracker so it's visible and recorded
b) We mention the pull request in standup, and have a specific wall area for cards that need to be merged
c) We set aside some time to look at pull requests during the day.

All this generally means we don't have to wait long to get things merged. Note that all 3 of those things are social fixes rather than technical - I'm not sure there's a good technical solution for this kind of thing.

Everyone is busy so there's always going to be some horse trading involved in getting things merged, it's just a matter of agreeing to share the pain.

On 19 Aug 2013, at 13:38, Matthew Rudy Jacobs <matthewrudyjacobs at gmail.com> wrote:

> (This is a process question, rather than a Ruby question)
> 
> How do you folks manage getting code from pull request to production?
> 
> At Enthuse.me we work in the following way;
> 	• we take a card
> 	• we work on the code until we believe it is done
> 	• we issue a pull request
> 	• another member of the team takes a look at the pull request
> 	• we converse about any issues
> 	• we make any changes
> 	• another member of the team merges the pull request
> 	• the code is deployed to the QA server
> 	• the product owner checks the function on QA
> 	• the code is deployed to Production
> This all seems to be fine,
> but the problem is context switching.
> 
> Steps 4 to 8 can take a couple of days to run through.
> 
> Maybe I finish the code on Friday, but no one is free to review it until Monday.
> I start working on something else, then someone raises an issue with my PR.
> When I'm next free I take a look, deal with their questions, make some changes, and ask them to take a look again.
> 
> That process takes a lot of time, and requires both the reviewer and myself, to switch back and forth.
> 
> How do you deal with this?
> 
> _______________________________________________
> Chat mailing list
> Chat at lists.lrug.org
> http://lists.lrug.org/listinfo.cgi/chat-lrug.org