[LRUG] [Workflow] Getting a Pull Request from creation to merge

[Najaf Ali]

*> 4. another member of the team takes a look at the pull request*
*
*
If I were looking I'd have a fresh CV/cover letter over to you faster than
you can say "horizontal privilege escalation".

*> How do you deal with this?*

One way I've seen this done before is to have a code review batman who is
designated as the person that does code reviews for that time period (be it
a week or whatever). Everyone does code reviews, always, but if there is no
one available and a change has been lingering/needs to be expedited, batman
rolls in and does the review. This only really works if your team is larger
than say ten developers.

Fun story: at one company we had a technical architect (who was demonic at
the command line *and* in his IDE) who was very good at context switching.
He managed to deliver a hell of a lot of high quality software, and
simultaneously code review literally everything a team of 20+ developers
did. Rumour had it that he was some sort of warlock or something, so YMMV.


On Mon, Aug 19, 2013 at 1:38 PM, Matthew Rudy Jacobs <
matthewrudyjacobs at gmail.com> wrote:

> (This is a process question, rather than a Ruby question)
>
> How do you folks manage getting code from pull request to production?
>
> At Enthuse.me we work in the following way;
>
>    1. we take a card
>    2. we work on the code until we believe it is done
>    3. we issue a pull request
>    4. another member of the team takes a look at the pull request
>    5. we converse about any issues
>    6. we make any changes
>    7. another member of the team merges the pull request
>    8. the code is deployed to the QA server
>    9. the product owner checks the function on QA
>    10. the code is deployed to Production
>
> This all seems to be fine,
> but the problem is context switching.
>
> Steps 4 to 8 can take a couple of days to run through.
>
> Maybe I finish the code on Friday, but no one is free to review it until
> Monday.
> I start working on something else, then someone raises an issue with my PR.
> When I'm next free I take a look, deal with their questions, make some
> changes, and ask them to take a look again.
>
> That process takes a lot of time, and requires both the reviewer and
> myself, to switch back and forth.
>
> How do you deal with this?
>
>
> _______________________________________________
> Chat mailing list
> Chat at lists.lrug.org
> http://lists.lrug.org/listinfo.cgi/chat-lrug.org
>
>


-- 
Ali, http://happybearsoftware.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lrug.org/pipermail/chat-lrug.org/attachments/20130819/db909b88/attachment-0003.html>