[LRUG] [Workflow] Getting a Pull Request from creation to merge

[Garry Shutler]

We use the :mag: emoji in a comment to signal it's ready for review and add
a /cc @whoever if there are particular people/groups that care.

*Garry Shutler*
@gshutler <http://twitter.com/gshutler>
gshutler.com


On 19 August 2013 14:18, Tim Cowlishaw <tim at timcowlishaw.co.uk> wrote:

> On 19 August 2013 14:02, George Sheppard <george at fuzzmonkey.co.uk> wrote:
>
> > Don't wait until you're finished to open the PR. I tend to open one
> early on
> > so other people are free to look through my code as they please. It also
> > makes it easier to ask people to have a look over something you're not
> sure
> > on. If you get feedback early rather than waiting until the end, you run
> > less risk of the 'have you seen gem X' or 'try using this approach'
> feedback
> > that can lead to delays while you refactor all the things.
>
> I've heard from other people about this approach, and I really like it
> in principle. However, given you've opened a PR early (presumably
> before the branch is ready to be merged), how do you then signal to
> the rest of the team that a PR is ready to be merged, rather than just
> 'in progress'? Via comments  or something more formal?
>
> Thanks,
>
> Tim
> _______________________________________________
> Chat mailing list
> Chat at lists.lrug.org
> http://lists.lrug.org/listinfo.cgi/chat-lrug.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lrug.org/pipermail/chat-lrug.org/attachments/20130819/90c933ec/attachment-0003.html>