[LRUG] [Workflow] Getting a Pull Request from creation to merge

[George Sheppard]

I normally have 'not ready' or 'do not merge' in the PR title / description then ping people once its actually ready for merging via a github comment or on campfire. I also remove the in progress message, so it tends to be fairly obvious when a PR is ready for merge.

I normally have a gut feeling about a branch / pull request. I tend to trust this and reach out to the rest of the team if I'm not sure on something just by pinging across the link to the PR with some comments. By discussing on the PR, even before its ready, there is some additional context for anyone reviewing at a later date. 

Regards,

George



On 19 Aug 2013, at 14:18, Tim Cowlishaw <tim at timcowlishaw.co.uk> wrote:

> On 19 August 2013 14:02, George Sheppard <george at fuzzmonkey.co.uk> wrote:
> 
>> Don't wait until you're finished to open the PR. I tend to open one early on
>> so other people are free to look through my code as they please. It also
>> makes it easier to ask people to have a look over something you're not sure
>> on. If you get feedback early rather than waiting until the end, you run
>> less risk of the 'have you seen gem X' or 'try using this approach' feedback
>> that can lead to delays while you refactor all the things.
> 
> I've heard from other people about this approach, and I really like it
> in principle. However, given you've opened a PR early (presumably
> before the branch is ready to be merged), how do you then signal to
> the rest of the team that a PR is ready to be merged, rather than just
> 'in progress'? Via comments  or something more formal?
> 
> Thanks,
> 
> Tim